openSUSE / agama / 9549010266

72%

Build Type

push

github

Committed by web-flow

Commit Message

fix(zypp): Fixed moving libzypp target to `/mnt` (#1352)

## Problem

- Moving the libzypp target to `/mnt` (the target installed system)
happened too early, already in the "propose" step, it needs to happen
after partitioning the disk.
- The side effect of this is that mounting the `/mnt` partition can
shadow the libzypp cache so it could crash later. Also the next target
used after the product change would be the `/mnt` instead of the
`/run/agama/zypp`.

## Solution

- Move the target change to the "install" step

## Notes

- I found out that the `Pkg.SourceCacheCopyTo` call does not work
properly with target different than `/`. It always copies the data from
`/` ignoring the current target.
- It could copy some wrong data from the Live ISO to the target, as a
quick solution I have commented that out. I'll fix it later in a
separate PR.

## Testing

- Tested manually
- Updated unit tests

Run Details

1987 of 2868 branches covered (69.28%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

39 existing lines in 2 files now uncovered.

18841 of 26518 relevant lines covered (71.05%)

34.43 hits per line