tarantool / luajit / 9545488673

70%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

Maintain chain invariant in DCE.

Thanks to Peter Cawley.

(cherry picked from commit f72c19e48)

Instructions with strong guards that are sometimes emitted with a guard
and sometimes emitted without a guard (like HREFK, CONV, or SLOAD) may
be eliminated from the IR chain and replaced with the NOP IR. If the
next IR of the same kind on the trace is not eliminated, it may
reference the IR NOP instead of an instruction of the same type. This
may lead to the corresponding assertion failure in the `rec_check_ir()`.

This patch unconditionally links the IRs during chain maintenance in
DCE.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#9924

Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit dbf132960)

Run Details

5640 of 6000 branches covered (94.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

24 existing lines in 6 files now uncovered.

21507 of 23329 relevant lines covered (92.19%)

898601.45 hits per line