linxGnu / gosmpp / 9525625296

82%

Build Type

push

github

Committed by web-flow

Commit Message

Feature: PDU SubmitWindow with; MaxWindowSize option,  ExpectedResponse handler, ExpiredPdus handler and  NoRespPdu OnClose handler (#134)

What: 
- Add a submit window via a
[concurrent-map](https://github.com/orcaman/concurrent-map) that tracks
Requests (SubmitSM, EnquireLinks, ReplaceSM, etc..)
- Add functionality to return a expected response with the original sent
PDU
- Add functionality to track PDUs with no response and a timer setting
for when they expire
- Add a max window size setting, to limit the number of outbound request
- Add function call to get current bind window size on Tx and Trx
- Add function call to get a PDU stuck in the submit store when the bind
closes.
- Add an example on how to use new settings
- Add an example on how to implemented a Custom PDU to add any fields to
be tracked

Why: As requested in #126, #105 and #73, the user sometimes needs to
track all requests sent to SMSC. Either to relate a response to a
request, or to track a request that have received no response or even to
limit the number of outgoing request without any response from the SMSC.

How: 
- The main feature, the submit window, works by using a
[concurrent-map](https://github.com/orcaman/concurrent-map) as a
key/value store. The key is the PDU sequence number and the value is a
new Request struct created for this feature. Concurrent-map is thread
safe and has all the functionality needed for this use case. The map
gets reset on every rebind and all PDUs stored in the map are can be
retruned to the user via a func call when the session is closed.
- When the user Submits a PDU, it is stored in the new Request struct
with the request is created
- When the library receives a PDU from the SMSC, it will verify if the
PDU is a response type (SubmitSMResp, ReplaceSMResp, etc) and queries
the key/value store with the sequence number. If the store contains a
PDU request, the response is returned to the user with the PDU and the
... (continued)

Run Details

182 of 275 new or added lines in 6 files covered. (66.18%)

5 existing lines in 4 files now uncovered.

599 of 742 relevant lines covered (80.73%)

75.41 hits per line