rust-bitcoin / rust-bitcoin / 9525063741

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2865: Refactor test module in `merkle_tree/block.rs`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/3f4eb07769e2605481574a8d4a9165e351b4b53b">3f4eb0776<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/45fe754ae3fa5fd158938b2abe95b79d6ab5b595"> Add a comment to regression test (Jamil Lambert, PhD)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/fc2876ba10f4a22baeecc337255c6661318b5c85">fc2876ba1</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/45fe754ae3fa5fd158938b2abe95b79d6ab5b595"> Move use statements to top of module (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/778a44dd64dd716e3bd398590cde4e7a9a3fe97a">778a44dd6</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/45fe754ae3fa5fd158938b2abe95b79d6ab5b595"> Refactor merkle block test (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c4c1252a9e41fbcf3a504de7d234a070e36d7335">c4c1252a9</a> Change encode path (Jamil Lambert, PhD)

Pull request description:

  Refactored the `extract_matches_from_merkleblock()` test function following https://github.com/rust-bitcoin/rust-bitcoin/pull/2859#issuecomment-2161710169.

  Moved use statements to the top of the test module and changed it to use one level of path instead of importing the function names.  e.g. `encode::serialize()` instead of `serialize()`.

  Added the missing comment to the `regression_2606()` test.  I was not sure where the hex value came from that was used to test that the deserialization fails.  The comment was generated by copilot and may need to be edited, it does fit with the error given by deserialize: `OversizedVectorAllocation { requested: 12811880876963004416, max: 4000000 }`.

ACKs for top commit:
  tcharding:
    ACK 3f4eb07769e2605481574a8d4a9165e351b4b53b
  apoelstra:
    ACK 3f4eb07769e2605481574a8d4a9165e351b4b53b the `prelude::*` is fine since it was already there since #298, but FYI I would not have accepted it today

Tree-SHA512: 203a30eee85120143c736a7d293b6029e0d

20 of 20 new or added lines in 1 file covered. (100.0%)

19546 of 23511 relevant lines covered (83.14%)

16250.39 hits per line