rust-bitcoin / rust-bitcoin / 9519354068

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#2852: Add inherent functions to hashes

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/18b2788a5ac8d052624cd23687d9628ecc557615">18b2788a5<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/72ce271b6b375067424d312742a0a46802ee5f62"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6b7d02e5ae0bb6a3d3ba0fe30da942200a171f70">6b7d02e5a</a> Add inherent functions to hashes (Tobin C. Harding)

Pull request description:

  Currently we have a trait `Hash` that is required for `Hmac`, `Hkdf`, and other use cases. However, it is unegonomic for users who just want to do a simple hash to have to import the trait.

  Add inherent functions to all hash types including those created with the new wrapper type macros.

  This patch introduces some duplicate code but we are trying to make progress in the hashes API re-write. We can come back and de-dublicate later.

  Includes making `to_byte_array`,`from_byte_array`, `as_byte_array`, and `all_zeros` const where easily possible.

ACKs for top commit:
  apoelstra:
    ACK 18b2788a5ac8d052624cd23687d9628ecc557615

Tree-SHA512: 6b7a8d8a8e2ca133b5571ca838c19c4e093

Run Details

98 of 144 new or added lines in 10 files covered. (68.06%)

4 existing lines in 1 file now uncovered.

19547 of 23512 relevant lines covered (83.14%)

16276.61 hits per line