kubevirt / containerized-data-importer / #4741

49%

push

travis-ci

Avoid a panic in test clean-up (#3322)

During test setup, pointer framework.ClientsInstance.K8sClient is
assigned.  During the test AfterEach phase, an Eventually loop accesses
this pointer.

If the test fails before this assignment, the after-each will panic.

Pointer assignment:
    https://github.com/kubevirt/containerized-data-importer/blob/<a class=hub.com/kubevirt/containerized-data-importer/commit/<a class="double-link" href="https://git"><a class=hub.com/kubevirt/containerized-data-importer/commit/b6392df9bf943f00c70ae71d37106cc12a576f19">b6392df9b/tests/tests_suite_test.go#L123
Panic in AfterEach, when calling GetTestNamespaceList:
    https://github.com/kubevirt/containerized-data-importer/blob/b6392df9bf943f00c70ae71d37106cc12a576f19/tests/tests_suite_test.go#L162
Which defereferences the client pointer in client.CoreV1():
    https://github.com/kubevirt/containerized-data-importer/blob/b6392df9bf943f00c70ae71d37106cc12a576f19/tests/utils/common.go#L136

Signed-off-by: Edu Gómez Escandell <egomez@redhat.com>

16286 of 27579 relevant lines covered (59.05%)

0.65 hits per line