kevinoid / NetCoreProject / 9505274511

86%

push

github

.editorconfig: Suggest for loop condition (S1994)

Although not checking the value changed by the for_iterator expression
in the for_condition expression of a for loop can be an error, it can
also be intentional behavior, such as using a variable to count retries:

```csharp
for (int attempt = 0; ; attempt++)
{
    try
    {
	...
    }
    catch (Exception)
    when (attempt < 3)
    {
	...
    }
}
```

Although this could be converted to a while statement, it would need an
additional level of indentation to limit the scope of the variable to
the loop.  Doing that, or disabling the warning in every case, seems to
outweigh the value added by this check.  Leave it as a suggestion only.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>

3 of 4 branches covered (75.0%)

Branch coverage included in aggregate %.

3 of 3 relevant lines covered (100.0%)

5.0 hits per line