• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

openSUSE / agama / 9499669760
72%

Build:
DEFAULT BRANCH: master
Ran 13 Jun 2024 12:34PM UTC
Jobs 3
Files 781
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

13 Jun 2024 12:31PM UTC coverage: 70.875% (+0.1%) from 70.773%
9499669760

push

github

web-flow
feat(web): remake the user interface (#1202)

As Agama has progressed, the original idea of a hyper-minimalist
interface has completely vanished. We have moved far away from the first
_SPA interactive interface_. The installation summary has lost all its
value and it is now a sort of navigation menu or index. Furthermore, it
is impossible to start with a valid configuration straight away due to
several reasons, such as

* The creation of a user it's mandatory since it cannot be relegated to
the first boot.
* The storage proposal algorithm [does not perform as many
attempts](https://github.com/openSUSE/agama/issues/1159#issuecomment-2082701802)
as it used to do in YaST.

Last but not least, it is way weird landing in a page with a big, green,
and enabled <kbd>Install</kbd> button that will prompt an error when
clicked before any other user interaction.

There is a [proposal to
improve](https://github.com/openSUSE/agama/discussions/778) that first
initial screen, but having in mind the Agama development progression I
believe that the current approach does not scale. Regrettably, looks
like a dead end.

With this in mind, I have been thinking a bit about an alternative that
I had on my to-do list for the future, which consisted of converting the
summary screen into a panel on the left and loading the content of each
section to the right (which would overlap the first on small devices).
It would solve two problems in one shot by stop forcing the user to
navigate back and forth to change between sections and stop wasting
available space on large screens. The key was to make better use of
react-router and embrace [nested
routes](https://reactrouter.com/en/main/start/overview#nested-routes) as
designed instead of fighting against them. Something perfectly doable.

However, as soon as I started writing some code to play with, I realized
that also embracing more heavily PatternFly would be enough to start
making it possible.... (continued)

1987 of 2868 branches covered (69.28%)

Branch coverage included in aggregate %.

194 of 241 new or added lines in 54 files covered. (80.5%)

311 existing lines in 34 files now uncovered.

18861 of 26547 relevant lines covered (71.05%)

34.38 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
59.68
0.0% web/src/client/mixins.js
1
90.0
0.0% web/src/components/network/ConnectionsTable.jsx
1
71.21
0.0% web/src/components/network/NetworkPage.jsx
1
88.89
0.0% web/src/components/network/WifiNetworkMenu.jsx
1
26.83
0.0% web/src/components/network/WifiSelector.jsx
1
87.5
0.0% web/src/components/overview/OverviewPage.jsx
1
92.45
0.0% web/src/components/overview/SoftwareSection.jsx
1
2.22
0.0% web/src/components/storage/DASDPage.jsx
1
4.21
0.0% web/src/components/storage/DASDTable.jsx
1
76.08
0.0% web/src/components/storage/ZFCPPage.jsx
2
44.34
0.0% rust/agama-server/src/network/web.rs
2
0.0
0.0% rust/agama-server/src/users/web.rs
2
18.87
0.0% web/src/client/network/index.js
2
2.7
0.0% web/src/components/network/AddressesDataList.jsx
2
3.85
0.0% web/src/components/network/DnsDataList.jsx
2
0.0
0.0% web/src/components/storage/DASDFormatProgress.jsx
4
61.11
5.56% service/lib/agama/dbus/users.rb
4
54.55
0.0% web/src/client/index.js
5
0.0
0.0% rust/agama-server/src/web.rs
5
2.9
0.0% web/src/components/network/IpSettingsForm.jsx
7
73.39
0.0% web/src/components/overview/StorageSection.jsx

Uncovered Existing Lines

Lines Coverage ∆ File
1
61.11
5.56% service/lib/agama/dbus/users.rb
1
92.45
0.0% web/src/components/overview/SoftwareSection.jsx
1
89.29
0.0% web/src/components/storage/BootConfigField.jsx
1
78.57
0.0% web/src/components/storage/DeviceSelectorTable.jsx
1
0.0
0.0% web/src/components/storage/ISCSIPage.jsx
1
93.1
0.0% web/src/components/storage/ProposalActionsDialog.jsx
1
0.0
0.0% web/src/components/users/UsersPage.jsx
2
97.78
4.03% service/service/lib/agama/users.rb
2
87.5
0.0% web/src/components/core/InstallButton.jsx
2
91.3
0.0% web/src/components/storage/EncryptionField.jsx
2
91.38
0.0% web/src/components/storage/VolumeLocationDialog.jsx
3
59.68
0.0% web/src/client/mixins.js
3
95.63
0.0% web/src/components/storage/VolumeDialog.jsx
4
65.85
0.0% web/src/client/users.js
4
80.49
0.0% web/src/components/network/WifiNetworkListItem.jsx
4
0.0
0.0% web/src/index.js
6
0.0
0.0% web/src/components/storage/DASDFormatProgress.jsx
6
82.35
0.0% web/src/components/storage/ProposalSettingsSection.jsx
7
54.55
0.0% web/src/client/index.js
8
87.27
0.0% web/src/components/users/FirstUser.jsx
10
44.34
0.0% rust/agama-server/src/network/web.rs
10
79.83
0.0% web/src/components/storage/ProposalPage.jsx
10
77.57
0.0% web/src/components/storage/VolumeFields.jsx
11
71.21
0.0% web/src/components/network/NetworkPage.jsx
11
73.39
0.0% web/src/components/overview/StorageSection.jsx
13
3.85
0.0% web/src/components/network/DnsDataList.jsx
17
0.0
0.0% rust/agama-server/src/web/common.rs
17
2.7
0.0% web/src/components/network/AddressesDataList.jsx
17
85.56
0.0% web/src/components/storage/PartitionsField.jsx
20
61.11
5.56% service/service/lib/agama/dbus/users.rb
22
2.9
0.0% web/src/components/network/IpSettingsForm.jsx
25
76.08
0.0% web/src/components/storage/ZFCPPage.jsx
32
4.21
0.0% web/src/components/storage/DASDTable.jsx
36
2.22
0.0% web/src/components/storage/DASDPage.jsx
Subprojects
ID Flag name Job ID Ran Files Coverage
3 service 9499669760.3 13 Jun 2024 12:34PM UTC 352
86.72
GitHub Action Run
3 rust 9486154225.3 12 Jun 2024 04:27PM UTC 86
23.37
GitHub Action Run
3 web 8937163624.3 03 May 2024 09:49AM UTC 343
75.3
GitHub Action Run
Source Files on build 9499669760
  • Tree
  • List 781
  • Changed 30
  • Source Changed 5
  • Coverage Changed 4
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #9499669760
  • 3df88835 on github
  • Prev Build on master (#9486154225)
  • Next Build on master (#9499669768)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc