finagle / finagle-postgres / 32

DEFAULT BRANCH: master
Ran
Jobs 6
Files 14
Run time 7min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
32

Pull #21

travis-ci

web-flow 
Better value decoding

This commit changes how values are decoded internally. It introduces the
`ValueDecoder` trait, which is responsible for decoding a value from either
text or binary using a particular strategy.

Additionally, OIDs are now used to map to the name of the postgres receive
function for a type, which is a reliable way of deciding how the value should
be decoded. These receive functions are then mapped to ValueDecoders.  This
change allows for cusom value decoders to be specified, and also allows for
the remote database to be queried for its types; custom types may be present
with a non-fixed OID, but which use existing receive functions.  Thus, type
handling is more robust against postgres use cases.

Changes to the user-facing API:
- Client.apply now accepts additional optional arguments:
  - `customReceiveFunctions` which allows for specifying a `PartialFunction` that
    maps receive function names to `ValueDecoder`s
  - `binaryResults` which allows specifying that the client should ask the server
    for results in binary format (which is more robust and performant than text)
- Timestamps now use appropriate `java.time` representations by default:
  - `java.time.LocalDateTime` for timestamp
  - `java.time.ZonedDateTime` for timestamp with time zone
  - `java.time.LocalDate` for date

Compatibility changes:
- Java 8 is now required (since `java.time` is used)

The integration tests have also been changed to use an environment-configurable
Postgres instance, rather than a hard-coded one.  This will allow the integration
tests to actually run in travis-ci.

Tests also now use ScalaCheck where possible.

There are also a few fixes for bugs which didn't become apparent until binary
mode was possible.
Pull Request #21: Better value decoding

264 of 264 new or added lines in 6 files covered. (100.0%)

93 of 832 relevant lines covered (11.18%)

0.34 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
0.0
 0.0% src/main/scala/com/twitter/finagle/postgres/messages/FrontendMessages.scala
3
0.0
 0.0% src/main/scala/com/twitter/finagle/postgres/Responses.scala
4
78.57
 -13.1% src/main/scala/com/twitter/finagle/postgres/values/Utils.scala
14
0.0
 0.0% src/main/scala/com/twitter/finagle/postgres/messages/BackendMessageParser.scala
95
0.0
 0.0% src/main/scala/com/twitter/finagle/postgres/Client.scala
146
0.0
 -17.43% src/main/scala/com/twitter/finagle/postgres/values/Values.scala

Uncovered Existing Lines

Lines Coverage ∆ File
1
0.0
 0.0% src/main/scala/com/twitter/finagle/postgres/codec/PgCodec.scala
1
80.0
 0.0% src/main/scala/com/twitter/finagle/postgres/connection/Connection.scala
1
37.86
 0.0% src/main/scala/com/twitter/finagle/postgres/connection/ConnectionStateMachine.scala
2
0.0
 0.0% src/main/scala/com/twitter/finagle/postgres/messages/FrontendMessages.scala
3
0.0
 -17.43% src/main/scala/com/twitter/finagle/postgres/values/Values.scala
3
0.0
 0.0% src/main/scala/com/twitter/finagle/postgres/Client.scala
13
0.0
 0.0% src/main/scala/com/twitter/finagle/postgres/messages/BackendMessageParser.scala
Jobs
ID Job ID Ran Files Coverage
1 32.1 (PG_HOST_PORT=localhost:5432) 0
Travis Job 32.1
2 32.2 (PG_USER=postgres) 0
Travis Job 32.2
3 32.3 (PG_DBNAME=finagle_postgres_test) 0
Travis Job 32.3
4 32.4 (PG_HOST_PORT=localhost:5432) 14
11.18
 Travis Job 32.4
5 32.5 (PG_USER=postgres) 14
11.18
 Travis Job 32.5
6 32.6 (PG_DBNAME=finagle_postgres_test) 14
11.18
 Travis Job 32.6
Source Files on build 32
Coverage ∆ File Lines Relevant Covered Missed Hits/Line