divviup / divviup-api / 9490969744
69%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 122
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 56.359% (-0.04%) from 56.402%
9490969744

push

github

web-flow 
Add image parameters to `compose.yaml` (#1092)

Compose files can be parameterized using Bash-style (*sigh*) syntax
([1]). We add variables `JANUS_AGGREGATOR_IMAGE`,
`JANUS_MIGRATOR_IMAGE`, `DIVVIUP_API_IMAGE` and
`DIVVIUP_API_MIGRATOR_IMAGE` to allow setting Docker image tags like so:

```sh
DIVVIUP_API_IMAGE=myrepository.dev/divviup_api:0.0.1 \
  JANUS_AGGREGATOR_IMAGE=myrepository.dev/janus_aggregator:0.7.8 \
  docker compose up
```

These variables are interpolated into the `image` field of the `service`
elements ([2]). 

We also add `compose.dev.yaml`, which includes the base
`compose.yaml` and adds overrides which remove the `image`
element from the `divviup-api` services and add a `build` instead. This
causes `docker compose` to build those images from local sources, on
demand.

We provide defaults for all these images that pull from Divvi Up owned
public artifact repositories. It's somewhat unfortunate that we use a
`divviup-api` version that is behind `main`, but on the other hand the
objective is to enable a demo experience, so it makes sense to pin
Janus and divviup-api versions where the demo is known to work
end-to-end.

[1]: https://docs.docker.com/compose/compose-file/12-interpolation/
[2]: https://docs.docker.com/compose/compose-file/05-services/#image
[3]: https://docs.docker.com/compose/compose-file/build/#using-build-and-image

3935 of 6982 relevant lines covered (56.36%)

106.72 hits per line

Jobs
ID Job ID Ran Files Coverage
1 9490969744.1 0
56.36
 GitHub Action Run
Source Files on build 9490969744
Detailed source file information is not available for this build.