rust-bitcoin / rust-bitcoin / 9470948209

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2851: hashes: Move non-trait functions

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/ce1db3ea267c257bd56f54e74b3081db6072713d">ce1db3ea2 hashes: Move non-trait functions (Tobin C. Harding)

Pull request description:

  The `hash_trait_impls` macro currently adds an impl block for `Hash` - this is not what the docs say since and `impl Hash` block is nothing to do with traits.

  Move the impl block and add a duplicate of the functions to the `sha256t::Hash` type.

  This is a refactor, no API or logic changes. Note that wrapper types currently do net get these functions - that will be discussed/implemented separately.

ACKs for top commit:
  apoelstra:
    ACK ce1db3ea267c257bd56f54e74b3081db6072713d Ok, this one is easy :)

Tree-SHA512: c25bc2bcf30ae4ce928e4844de798717756

8 of 16 new or added lines in 2 files covered. (50.0%)

19481 of 23408 relevant lines covered (83.22%)

16561.66 hits per line