Qiskit / rustworkx / 9447555728

94%

push

github

Move `collect_bicolor_runs()` to rustworkx-core (#1186)

* Attempt with graph.node_weight

* Progress until hitting  error.

* Return node ids instead of node weights. Code compiles!!!

* Move collect_bicolor_runs.rs to rustworkx-core/src/dag_algo.rs

* Add pyo3 wrapper for core collect_bicolor_runs, modify test, small fixes.

* Fix DagHasCycle error to match previous type

* Clean up unused parameters and functions, simplify error handling, add unit tests and reno.

* Use PyResult, fix comments

* Apply feedback from Matt's review, make tests make more sense.

* Add suggestion from Matt's code review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Remove stray print

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Change callbacks to take ids instead of weights, rename some variables in tests for clarity.

* Fix test

* Apply suggestions from  code review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Get rid of unused trait

* Fix fmt

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

96 of 97 new or added lines in 2 files covered. (98.97%)

17388 of 18135 relevant lines covered (95.88%)

1163280.96 hits per line