• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

uber / cadence / 018fef90-a615-49da-9a34-4252dfbfb34c
72%

Build:
DEFAULT BRANCH: master
Ran 06 Jun 2024 10:33PM UTC
Jobs 1
Files 719
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

06 Jun 2024 09:59PM UTC coverage: 71.402% (+0.02%) from 71.379%
018fef90-a615-49da-9a34-4252dfbfb34c

push

buildkite

web-flow
Global ratelimiter: client-side Collection skeleton (#6078)

A half-fleshed-out skeleton of the quotas.Collection that the frontend will use for these limits,
and a chunk of pseudo-code to show how it'll be used when the RPC PR is ready (coming soon).

This is not completely usable right now and will likely need some small changes, but it has the core bits:
- real limiters / fallbacks / tracking
- dynamically-tweakable background update loop
- logs, metrics, error handling (where reasonable)
- some very simple tests

It will eventually need:
- sharding the limiters by key for all the (relevant) aggregator hosts
- dynamic config to shadow / disable global limiters and control sending update requests.
- swapping the frontend handler's ratelimits to use this instead

94 of 136 new or added lines in 2 files covered. (69.12%)

14 existing lines in 5 files now uncovered.

106456 of 149093 relevant lines covered (71.4%)

2594.4 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
42
67.19
common/quotas/global/collection/collection.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
89.05
0.5% common/task/weighted_round_robin_task_scheduler.go
2
86.94
-0.41% service/history/task/transfer_standby_task_executor.go
2
82.21
-1.23% service/matching/tasklist/task_writer.go
3
96.2
-0.19% service/history/handler/handler.go
6
79.33
-0.92% service/history/task/timer_active_task_executor.go
Jobs
ID Job ID Ran Files Coverage
1 018fef90-a615-49da-9a34-4252dfbfb34c.1 06 Jun 2024 10:33PM UTC 719
71.4
Source Files on build 018fef90-a615-49da-9a34-4252dfbfb34c
  • Tree
  • List 719
  • Changed 305
  • Source Changed 0
  • Coverage Changed 14
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • c22b65fe on github
  • Prev Build on master (#018FEF52...)
  • Next Build on master (#018FEFA1...)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc