divviup / divviup-api / 9407795970

69%

Build Type

push

github

Committed by web-flow

Commit Message

Fix extant clippy diagnostics (#1074)

Besides applying a variety of `clippy` suggestions, this neuters
`clippy::cargo_common_metadata` ([1]) and
`clippy::multiple_crate_versions` ([2]) in several targets. Neither
warning is very useful: the former nags us to set keywords and such on
every package (which we don't do for Janus crates and have never lost
sleep over) and while the dep duplication flagged by the latter is
unfortunate, it's inevitable for any nontrivial Rust dependency tree. We
also no longer need to allow `clippy::needless_pass_by_ref_mut` ([3]).

[1]: https://rust-lang.github.io/rust-clippy/master/index.html#/cargo_common_metadata
[2]: https://rust-lang.github.io/rust-clippy/master/index.html#/multiple_crate_versions
[3]: https://rust-lang.github.io/rust-clippy/master/index.html#/needless_pass_by_ref_mut

Coverage Stats

4 of 16 new or added lines in 13 files covered. (25.0%)

4 existing lines in 3 files now uncovered.

3933 of 6856 relevant lines covered (57.37%)

108.18 hits per line