ooni / probe-cli / 9399938815

72%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: move engine.InputLoader to targetloading (#1616)

This commit moves the engine.InputLoader type to a new package called
inputloading and adapts the naming to avoid stuttering. We therefore
have engine.InputLoaderSession => targetloading.Session and other
similar renames.

The reason for moving InputLoader is that the engine package depends on
registry, and, per the plan described by the first richer input PR,
https://github.com/ooni/probe-cli/pull/1615, we want to move target
loading directly inside the registry. To this end, we need to move the
target loading feature outside of engine to avoid creating import loops,
which prevent the code from compiling because Go does not support them.

While there, name the package targetloading rather than inputloading
since richer input is all about targets, where a target is defined by
the (input, options) tuple. Also, try to consistently rename types to
mention targets.

We keep an integration test inside the engine package because it seems
such an integration test was checking both engine and the Loader
together. We may further refactor this test in the future.

Part of https://github.com/ooni/probe-cli/pull/1612

---------

Co-authored-by: DecFox <33030671+DecFox@users.noreply.github.com>

Run Details

33 of 43 new or added lines in 9 files covered. (76.74%)

7 existing lines in 2 files now uncovered.

27443 of 32952 relevant lines covered (83.28%)

51.93 hits per line