vispy / vispy / 9398089489

75%

Build Type

push

github

Committed by web-flow

Commit Message

Raise ValueError when setting relative_step_size 0 or negative (#2595)

See discussion in #2589 

This changes the the `relative_step_size` setter to:
* raise a `ValueError` when setting to 0 or a negative value
* warn when setting small values between 0 and `side_len / (2 *
MAX_CANVAS_SIZE)`
* silently comply otherwise

This is closer to the previous behavior, and I think makes intuitive
sense (step size <=0 is non-sensical and could cause degenerate behavior
in the shader).

A bit confusing - there is a test for this and it passed on #2589
checks:

https://github.com/vispy/vispy/blob/4f061ba23/vispy/visuals/tests/test_volume.py#L46-L48

Run Details

5792 of 10518 branches covered (55.07%)

3 of 3 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

23958 of 32047 relevant lines covered (74.76%)

2.45 hits per line