018fead2-aa16-413b-ab6a-987f535deb2d
72%

Ran 06 Jun 2024 12:30AM UTC

Jobs 1

Files 718

Run time 2min

Badge

Embed ▾

Committed 05 Jun 2024 11:53PM UTC coverage: 71.176% (+0.009%) from 71.167%

Build # 018fead2-aa16-413b-ab6a-987f535deb2d

Build Type

push

buildkite

Committed by

web-flow

Commit Message

Skip .git folder when searching for *.go files (#6118)

Apparently that was being searched, and it noticed a "thing.go" folder that git made!
So now this has two improvements:
1. it does not step into the `.git` folder, because obviously there is no source that needs formatting in there
2. it only finds files, `-type f`, because directories aren't source files

Both pretty obviously good to have in retrospect.

---

A way to validate this kind of change for the future:
1. change the `SHELL = ...` line near the top of the makefile to include a `-x` debug flag.
   `make` will now print all the shell commands it runs, including this `find`.
2. copy it and run it by hand and check the output.
   in particular, this time I just had it find _all_ files to check where it looked, and made sure the list was reasonable
   (it included my local .idea, but that seems fine, it's small and has no go files)

I should've done 2 earlier when I added this `find` command, I likely would have noticed the directories and `.git` and removed them.  Sorry about that.

Run Details

106016 of 148949 relevant lines covered (71.18%)

2595.92 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	018fead2-aa16-413b-ab6a-987f535deb2d.1	06 Jun 2024 12:30AM UTC	0	71.18

Source Files on build 018fead2-aa16-413b-ab6a-987f535deb2d

Detailed source file information is not available for this build.

uber / cadence / 018fead2-aa16-413b-ab6a-987f535deb2d
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 018fead2-aa16-413b-ab6a-987f535deb2d

uber / cadence / 018fead2-aa16-413b-ab6a-987f535deb2d 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 018fead2-aa16-413b-ab6a-987f535deb2d

uber / cadence / 018fead2-aa16-413b-ab6a-987f535deb2d
72%

README BADGES
x