stacklok / minder / 9382331027

53%

Build Type

push

github

Committed by web-flow

Commit Message

Validate provider config when creating the OAuth provider or the GitHub App provider. (#3535)

* Handle validation errors for OAuth providers

Adds a new error ErrProviderInvalidConfig that is returned if the
ValidateConfig method of the provider Manager fails. This allows the
handlers to catch this error and display its details.

Fixes: #3510

* Validate GitHub App provider configuration on create

Adds the call to clients.ParseV1AppConfig to the code that creates GH
apps and returns the providers.ErrProviderInvalidConfig if the parsing
fails.

Catches the providers.ErrProviderInvalidConfig in the handler code to
display a user-friendly message.

Fixes: #3510

Run Details

25 of 25 new or added lines in 5 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

10508 of 19754 relevant lines covered (53.19%)

52.59 hits per line