babelfish-for-postgresql / babelfish_extensions / 9379186891

74%

BABEL_5_X_DEV: 77%

push

github

Fixed implementation of remove_accents_internal to better manage the memory (#2643)

In previous implementation of remove_accents_internal, we were passing input string to utrans_transUChars which will modify the string in place in order to remove the accents. And memory for the input string was also not well allocated in order to accommodate this expansion of string by utrans_transUChars causing the function to write out of allocated heap. This may cause various issues, for example,

Error like "pfree called with invalid pointer 0x149fb5b3c050 (header 0x0069032703270327)"
warnings like "problem in alloc set ExprContext: detected write past chunk end in block 0x35c6770, chunk 0x35c67e8" and "detected write past chunk end in ExprContext 0x2b24f48"
even result in server crash while allocating or freeing the memory
This commit fixes the implementation of remove_accents_internal to rightly calculate the capacity and allocate the enough memory to input string to handle possible expansion of the string by utrans_transUChars.

Task: BABEL-5006
Signed-off-by: Dipesh Dhameliya <dddhamel@amazon.com>

12 of 14 new or added lines in 1 file covered. (85.71%)

41723 of 57002 relevant lines covered (73.2%)

108030.62 hits per line