goto / guardian / 9363017926

66%

push

github

feat(appeal): added patch appeal API (#150)

* feat(appeal): added patch appeal API

* feat(appeal): created new error types

* feat(appeal): added tests for appeal service

* feat(appeal): added test for service layer

* feat(appeal): fixed failing test for repository

* feat(appeal): review suggestions

* feat(edit-appeal): refactor

* feat(edit-appeal): added audit log

* feat(edit-appeal): updated proton commit

* feat(edit-appeal): refactored handler layer

* feat(edit-appeal): added loggers

* feat(edit-appeal): removed logs

* feat(edit-appeal): allow to update fields even if similar appeal is pending in case resource/role/account_id is not changed

* feat(edit-appeal): fixed updateApproval repository method

* feat(edit-appeal): added test for UpdateByID repository function

* feat(approval): added new filter to filter approvals based on stale status

* feat(edit-appeal): updated proto commit

* feat(edit-appeal): updated db schema

* feat(edit-appeal): update stale approvals on updating appeal record

* feat(edit-appeal): removed update approval method

* feat(edit-appeal): update appeal with full assosciation and save updated grants as well

* feat(edit-appeal): store audit log object instead of json string

* feat(edit-appeal): updated auditlog format

* feat(edit-appeal): update db migration serial number

* feat(edit-appeal): updated Patch Appeal request payload

* feat(edit-appeal): updated path for audit logs

* feat(edit-appeal): send notification for updated approvals

* feat(edit): remove revision diff from auditLog

* feat(edit-appeal): wrap error for invalid status

Co-authored-by: Rahmat Hidayat <rahmatramahidayat@gmail.com>

* chore: restore removed test cases

* chore: make proto

* chore: call notify func concurrently

* chore: update error message

* chore: send audit log concurrently

* fix: fix mis-updated error message

---------

Co-authored-by: Ayus... (continued)

303 of 437 new or added lines in 7 files covered. (69.34%)

9970 of 13282 relevant lines covered (75.06%)

4.9 hits per line