c-ares / c-ares / #938

92%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Basic support for SIG RR record (RFC 2931 / RFC 2535) (#773)

With the current c-ares parser, as per PR #765 parsing was broken due to
validation that didn't understand the `SIG` record class. This PR adds
basic, non validating, and incomplete support for the `SIG` record type.
The additional `KEY` and `NXT` which would be required for additional
verification of the records is not implemented. It also does not store
the raw unprocessed RR data that would be required for the validation.

The primary purpose of this PR is to be able to recognize the record and
handle some periphery aspects such as validation of the class associated
with the RR and to not honor the TTL in the RR in the c-ares query cache
since it will always be 0.

Fixes #765
Fix By: Brad House (@bradh352)

Run Details

108 of 133 new or added lines in 5 files covered. (81.2%)

1 existing line in 1 file now uncovered.

8680 of 10783 relevant lines covered (80.5%)

3939.77 hits per line