stacklok / minder / 9314096182

53%

Build Type

push

github

Committed by web-flow

Commit Message

Remove algorithm from crypto config (#3467)

Relates to #3315

Previously, it was possible to set a default and fallback algorithm.
This seemed like a good idea at the time but I came to realize the
following:

1) Unlike the key, the algorithm is not an external piece of data - it
   corresponds to something implemented in the codebase. We cannot
   introduce new algorithms without changing the code.
2) After pairing on a key rotation with Ozz, I realized that the
   relationship between the key ID and the algorithm in the config is
   not really intuitive, and is likely to cause confusion which could
   result in us breaking our ability to decrypt secrets.

This PR removes the algorithm from the config and defines the default vs
fallback in the code. As part of this change, the new GCM algorithm
becomes the default for everyone, and this required changing some tests
to use real encryption keys (the old CFB algorithm would accept
arbitrary strings as keys, the GCM cipher expects a base64-encoded
32-byte key).

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

9 existing lines in 1 file now uncovered.

10082 of 19260 relevant lines covered (52.35%)

53.71 hits per line