safe-global / safe-client-gateway / 9287126413

89%

push

github

Checksum `contractAddress` of contract fetching and propagate type (#1596)

Checksums the incoming `contractAddress` of `ContractsController['getContract']` and propagates the stricter (`0x${string}`) type throughout the project accordingly:

- Add validation pipe checksum to incoming `contractAddress` of `ContractsController['getContract']`
- Make the `contractAddress` type of `ContractsService['getContract']` stricter
- Checksum the `sender` and `recipient` addresses in `Erc20TransferMapper`/`Erc721TransferMapper`
- Checksum address mapping values in `Erc20TransferMapper`, `Erc721TransferMapper`, `SettingsChangeMapper`and `TransactionDataMapper`
- Make the `contractAddress` type of `ITransactionApi['getContract']` (and it's implementation) stricter
- Make the `address` type of `AddressInfoHelper['get' | 'getOrDefault' | 'getCollection' | '_getFromSource']` stricter
- Make the `contractAddress` type of `IContractsRepository['getContract']` (and it's implementation) stricter
- Make contracts cache dir `contractAddress` type stricter
- Update types/tests accordingly

2018 of 2463 branches covered (81.93%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 5 files covered. (100.0%)

7115 of 7370 relevant lines covered (96.54%)

325.36 hits per line