rust-bitcoin / rust-bitcoin / 9256032072

83%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#2806: Make Address:p2sh_from_hash public

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/74663827b12fabad8fede1b245e6c26f24111e21">74663827b Make Address:p2sh_from_hash public (Tobin C. Harding)

Pull request description:

  We previously made this function Private and added a comment that doing so was somehow better to remove the footgun of hashing the wrong length script. However in hindsight this was a bad idea and users want the functionality.

  Make the `Address:p2sh_from_hash` public and document it as we do for `Address::p2sh`.

  This is a backport of patch 1 from #2795, patch 2 is an update to api files which don't exist on the `\0.32.x` release branch.

ACKs for top commit:
  apoelstra:
    ACK 74663827b12fabad8fede1b245e6c26f24111e21

Tree-SHA512: 880ae255c671e49c8a96d00b5ef3395fab0

1 of 1 new or added line in 1 file covered. (100.0%)

19192 of 23087 relevant lines covered (83.13%)

16827.53 hits per line