37
100%

Ran 13 Apr 2014 01:37AM UTC

Jobs 3

Files 5

Run time 44s

Badge

Embed ▾

pending completion

Build # 37

Build Type

Pull #17

travis-ci

Committed by

theckman

Commit Message

try to improve TunnelBroker::Client

The `build_messenger_config()` method was seen as being too complex in CodeClimate so this attempts to address that. Also, increase release version to `0.0.11`.

I've reduced `build_messenger_config()` to just iterate over the config fields. For each item it calls `config_hash_item()` and merges the result of that in to the running config hash.

`config_hash_item()` returns a Hash to be merged in to the config hash:
- When given an invalid config key it raises a NoMethodError (maybe this should be a custom Exception)
- When the key is `:url` and config.url is unset, it defaults to the `ENDPOINT` constant
- When the config key is valid, and set, it returns a Hash with `{ :keyname => config.keyname }`
- When the config key is unset, and not url, return an empty Hash

Pull Request Pull Request #17: try to improve TunnelBroker::Client

Run Details

101 of 101 relevant lines covered (100.0%)

20.67 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	37.1 (2.1.1)	13 Apr 2014 01:38AM UTC	100.0	Travis Job 37.1
2	37.2 (2.1.0)	13 Apr 2014 01:37AM UTC	100.0	Travis Job 37.2
3	37.3 (2.0.0)	13 Apr 2014 01:37AM UTC	100.0	Travis Job 37.3

Source Files on build 37

Detailed source file information is not available for this build.

theckman / tunnelbroker / 37
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37

theckman / tunnelbroker / 37 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37

theckman / tunnelbroker / 37
100%

README BADGES
x