openSUSE / agama / 9253140703

72%

Build Type

push

github

Committed by web-flow

Commit Message

fix: Clippy warnings (#1231)

Fix almost all clippy warnings (some of them were automatically fixed
with `cargo clippy --fix`).

Note: there are still some warnings that require more work to get rid of
them:

<details>
<summary><i>$ cargo clippy</i></summary>

~~~
cargo clippy
Checking agama-server v0.1.0
(/home/ivan/projects/suse/code/agama/rust/agama-server)
warning: module has the same name as its containing module
 --> agama-server/src/l10n.rs:5:1
  |
5 | pub mod l10n;
  | ^^^^^^^^^^^^^
  |
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
  = note: `#[warn(clippy::module_inception)]` on by default

warning: very complex type used. Consider factoring parts into `type`
definitions
   --> agama-server/src/network/nm/proxies.rs:849:28
    |
849 | fn addresses(&self) -> zbus::Result<Vec<(Vec<u8>, u32, Vec<u8>)>>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
    = note: `#[warn(clippy::type_complexity)]` on by default

warning: very complex type used. Consider factoring parts into `type`
definitions
   --> agama-server/src/network/nm/proxies.rs:879:25
    |
879 | fn routes(&self) -> zbus::Result<Vec<(Vec<u8>, u32, Vec<u8>,
u32)>>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

warning: `agama-server` (lib) generated 3 warnings
warning: current MSRV (Minimum Supported Rust Version) is `1.74.0` but
this item is stable since `1.75.0`
   --> agama-server/src/agama-web-server.rs:233:22
    |
233 |         if addr.ip().to_canonical().is_loopback() {
    |                      ^^^^^^^^^^^^^^
    |
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv... (continued)

Run Details

1987 of 2868 branches covered (69.28%)

Branch coverage included in aggregate %.

19 of 99 new or added lines in 16 files covered. (19.19%)

3 existing lines in 2 files now uncovered.

18691 of 26520 relevant lines covered (70.48%)

31.92 hits per line