qunitjs / qunit / 9244492907

89%

main: 90%

Build Type

push

github

Committed by Krinkle

Commit Message

Core: Deprecate unset timeout for tests taking longer than 3 seconds

Up until now, QUnit has not defined or enforced any default timeout.
This means if your test timed out or got stuck, this would be silent
and could (depending on how you run/integrate your tests) be hard to
find the cause of, and might take a long time to even detect as it
would be subject to a higher-level timeout (e.g. some kind of maximum
process time or CI limit).

In QUnit 3.0, the default timeout will change from undefined
(effectively Infinity) to 3 seconds. This only effects you if you
* do not have `QUnit.config.testTimeout` set,
* and, have one or more tests exceeding 3 seconds,
* and, are not calling `assert.timeout()` inside this test.

Starting in QUnit 2.21, a deprecation warning will be logged, at most
once per test run, if you have no timeout defined, and a test takes
longer than 3 seconds. You can prepare yourself for QUnit 3 when this
happens by calling `assert.timeout()` inside those tests, or by
setting `QUnit.config.testTimeout` globally with a higher timeout
as-needed.

Run Details

5 of 5 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

1843 of 2078 relevant lines covered (88.69%)

2137.04 hits per line