babelfish-for-postgresql / babelfish_extensions / 9241672976
74%
BABEL_4_X_DEV: 75%

LAST BUILD BRANCH: BABEL_3_X_DEV
DEFAULT BRANCH: BABEL_4_X_DEV
Ran
Jobs 1
Files 114
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 73.184% (-0.003%) from 73.187%
9241672976

push

github

web-flow 
Fix Casting issue from Geometry to Bytea/Varbinary with SRID 0 (#2615)

For Geometry with SRID = 0, when we CAST from geometry to bytea/varbinary, PostGIS considers SRID 0 as SRID UNKNOWN, which prevents it from adding SRID bytes in the resulting varlena(bytea) format, producing incorrect result in babelfish. To handle this we have added an additional wrapper check to identify SRID 0 and then we produce the result in the driver expected format manually by prepending the SRID bytes.

# Input
select cast(geometry::STGeomFromText('Point(47.65100 -22.34900)', 0) AS varbinary)

# previous output (wrong output)               
geometry__stgeomfromtext              
--------------------------------------------------
0x17D9CEF7010C53D34740D34D6210585936C0

# current output (correct output)
geometry__stgeomfromtext                                      
-------------------------------------------------------------
0x00000000010C17D9CEF753D34740D34D6210585936C0

# Input
select cast(geometry::STGeomFromText('Point(47.65100 -22.34900)', 0) AS bytea)

# previous output (wrong output)               
geometry__stgeomfromtext              
--------------------------------------------------
0x17D9CEF7010C53D34740D34D6210585936C0

# current output (correct output)
geometry__stgeomfromtext                                      
-------------------------------------------------------------
0x00000000010C17D9CEF753D34740D34D6210585936C0

Task: BABEL-4986

Signed-off-by: Anikait Agrawal agraani@amazon.com

41709 of 56992 relevant lines covered (73.18%)

106438.43 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
2
70.48
 -0.44% contrib/babelfishpg_tds/src/backend/tds/tdsutils.c
Jobs
ID Job ID Ran Files Coverage
1 9241672976.1 114
73.18
 GitHub Action Run
Source Files on build 9241672976