rust-bitcoin / rust-bitcoin / 9238247099

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2795: Make `Address:p2sh_from_hash` public

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/3615410d215222ca5fdb431706007a36df5c797d">3615410d2<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/4fde89f77cbf6da389346d48b3f4da8c9c73357b"> api: Run just check-api (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/a3d2d1a184586eeb5a85efd2eace15ca9f388c7e">a3d2d1a18</a> Make Address:p2sh_from_hash public (Tobin C. Harding)

Pull request description:

  We previously made this function Private and added a comment that doing so was somehow better to remove the footgun of hashing the wrong length script. However in hindsight this was a bad idea and users want the functionality.

  Make the `Address:p2sh_from_hash` public and document it as we do for `Address::p2sh`.

  This is an additive change and is expected to be backported to `v0.32`, as part of the fix to #2784. Please note it introduces the footgun that is described in the function rustdoc. This will be improved as a separate patch and added to the current release.

ACKs for top commit:
  apoelstra:
    ACK 3615410d215222ca5fdb431706007a36df5c797d

Tree-SHA512: 535bb789482d1c116e8f07ad28343627bef

1 of 1 new or added line in 1 file covered. (100.0%)

19320 of 23190 relevant lines covered (83.31%)

16656.65 hits per line