safe-global / safe-smart-account / 9224438831

94%

push

github

Create a separate interface for module guard (#758)

Fixes #755 

Summary of changes:

- The PR creates a separate interface for Module guards instead of
having a single `Guard` interface for both module transactions and Safe
transactions.

- The new Module guard interface i.e,
[IModuleGuard](https://github.com/safe-global/safe-smart-account/pull/758/files#diff-82762908bf938d454d8a207aad1ec3839R10)
has two functions:
1. `checkModuleTransaction`
2. `checkAfterExecution`

- The [updated
addresses](https://github.com/safe-global/safe-smart-account/pull/758/files#diff-f567630e80a8de13632297dbd68a6f181R18)
in migration contracts are taken from logs from the tests.

- Rename interface `Guard` to `ITransactionGuard`. 

- Fix typo: Rename `ModuleTransasctionDetails` to
`ModuleTransactionDetails`

Codesize:
Main branch:

```
Safe 21210 bytes (limit is 24576)
SafeL2 22052 bytes (limit is 24576)
```


This PR (+571 bytes):
```
Safe 21781 bytes (limit is 24576)
SafeL2 22623 bytes (limit is 24576)
```

Changes in PR:
- [x] Documentation
- [x] Fix test cases
- [x] Rebase branch
- [x] Migration contracts

Open for discussion:

1. Rename `Guard` to `ITransactionGuard`? -> Yes
2. Rename `setGuard` function to `setTransactionGuard`? : Impacts Safe
interface
3. Rename `ChangedGuard` event to `ChangedTransactionGuard`? Impacts
services monitoring this event

---------

Co-authored-by: Shebin John <admin@remedcu.com>
Co-authored-by: Mikhail <16622558+mmv08@users.noreply.github.com>
Co-authored-by: Nicholas Rodrigues Lordello <n@lordello.net>

253 of 290 branches covered (87.24%)

Branch coverage included in aggregate %.

13 of 18 new or added lines in 6 files covered. (72.22%)

388 of 400 relevant lines covered (97.0%)

97.58 hits per line