9222527733

Committed 24 May 2024 10:28AM UTC coverage: 92.904% (-0.008%) from 92.912%

Build # 9222527733

Build Type

push

github

Committed by

web-flow

Commit Message

Checksum `safeAddress` of balance fetching and propagate type (#1567)

Checksums the incoming `safeAddress` of `BalancesController['getBalances']` and propagates the stricter (`0x${string}`) type throughout the project accordingly:

- Add validation pipe checksum to incoming `safeAddress` of `BalancesController['getBalances']`
- Update `safeAddress` argument of `BalancesService['getBalances | clearBalance']`
- Update `safeAddress` argument type of `IBalancesRepository['getBalances | clearBalance']` and all implementor
- Update `safeAddress` argument type of `IBalancesApi['getBalances']` and all implementors (Safe/Zerion)
- Update `safeAddress` type of Safe/Zerion balance cache
- Propagate type through getting Safe overviews, after checksumming address in `Caip10AddressesPipe`
- Update types/tests accordingly

Run Details

2028 of 2474 branches covered (81.97%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

7124 of 7377 relevant lines covered (96.57%)

326.84 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.33

/src/routes/safes/pipes/caip-10-addresses.pipe.ts

import { PipeTransform, Injectable } from '@nestjs/common';
import { getAddress } from 'viem';

@Injectable()
export class Caip10AddressesPipe
  implements PipeTransform<string, Array<{ chainId: string; address: string }>>
{
  transform(data: string): Array<{
    chainId: string;
    address: string;
  }> {
    const addresses = data.split(',').map((caip10Address: string) => {
      const [chainId, address] = caip10Address.split(':');

      return { chainId, address: getAddress(address) };
    });

    if (addresses.length === 0 || !addresses[0].address) {
      throw new Error(
        'Provided addresses do not conform to the CAIP-10 standard',
      );
    }

    return addresses;
  }
}

1	import { PipeTransform, Injectable } from '@nestjs/common';	100✔
2	import { getAddress } from 'viem';	100✔
3
4	@Injectable()
5	export class Caip10AddressesPipe	100✔
6	implements PipeTransform<string, Array<{ chainId: string; address: string }>>
7	{
8	transform(data: string): Array<{
9	chainId: string;
10	address: string;
11	}> {
12	const addresses = data.split(',').map((caip10Address: string) => {	28✔
13	const [chainId, address] = caip10Address.split(':');	54✔
14
15	return { chainId, address: getAddress(address) };	54✔
16	});
17
18	if (addresses.length === 0 \|\| !addresses[0].address) {	22!
UNCOV 19	throw new Error(	×
20	'Provided addresses do not conform to the CAIP-10 standard',
21	);
22	}
23
24	return addresses;	22✔
25	}
26	}

safe-global / safe-client-gateway / 9222527733

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous