safe-global / safe-client-gateway / 9222527733

89%

Build Type

push

github

Committed by web-flow

Commit Message

Checksum `safeAddress` of balance fetching and propagate type (#1567)

Checksums the incoming `safeAddress` of `BalancesController['getBalances']` and propagates the stricter (`0x${string}`) type throughout the project accordingly:

- Add validation pipe checksum to incoming `safeAddress` of `BalancesController['getBalances']`
- Update `safeAddress` argument of `BalancesService['getBalances | clearBalance']`
- Update `safeAddress` argument type of `IBalancesRepository['getBalances | clearBalance']` and all implementor
- Update `safeAddress` argument type of `IBalancesApi['getBalances']` and all implementors (Safe/Zerion)
- Update `safeAddress` type of Safe/Zerion balance cache
- Propagate type through getting Safe overviews, after checksumming address in `Caip10AddressesPipe`
- Update types/tests accordingly

Run Details

2028 of 2474 branches covered (81.97%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

7124 of 7377 relevant lines covered (96.57%)

326.84 hits per line