rust-bitcoin / rust-bitcoin / 9210228058

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2773: reduce two-ACK requirement to one-ACK requirement

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/f3d364ef1da37cbe7dae7be8dbc5ffcd3bb9bf08">f3d364ef1 reduce two-ACK requirement to one-ACK requirement (Andrew Poelstra)

Pull request description:

  For the last few months it has only been myself and tcharding working on this project actively. Prior to that we had Kixunil as well, which allowed us to move forward requiring two ACKs on every PR (though it put a minimum 24-hour delay on everything since we are pairwise 8 hours separated from each other in timezones).

  The other listed maintainers, especially Sanket and Matt, are intermittently available, which is awesome but insufficient to get large refactors or long-term work through.

  We have increasingly depended on the "one-ACK carveout", an ever-increasing list of exceptions to our two-ACK rule. Most silly, one exception is that if something stays open for two weeks, we don't need the second ACK. So the result is a "one ACK plus 2 weeks" policy which is grating and demoralizing.

  Meanwhile, we are not finished our crate-smashing project or our API overhaul, and we want to continue moving at a fast rate. (Though of course, we will take breakage seriously; we do not want to make gratuitous changes or changes that replace previous changes, and the changes we *do* make we will do our damnedest to do via a year-long deprecation cycle. And we welcome suggestions to improve our policy or process on this front. But requiring extra maintainers/reviewers has not been helpful for us.)

  I'll let this PR sit open for 7 days (til Wed May 22) to accumulate ACKs or NACKs, and assuming no strong opposition, will merge it.

ACKs for top commit:
  sanket1729:
    ACK f3d364ef1da37cbe7dae7be8dbc5ffcd3bb9bf08

Tree-SHA512: 6d1ea41cec61b4dd8e20d7b25c8050578ae

19313 of 23176 relevant lines covered (83.33%)

16767.54 hits per line