eclipse-bluechi / bluechi / 9203243489

83%

push

github

Fix to get peer ip address

If we try to read the IP address from a struct sockaddr_in while
getpeername() filled it with struct sockaddr_in6 information, we are
actually reading the sin6_flowinfo part of the struct sockaddr_in6. That
flow information is usually zero, unless the connection is explicitely
flagged with a flow ID. So we would read a zeroed IP address.

Reference: https://stackoverflow.com/a/25640794

AS-IS

root@42dot-ak7:~# bluechictl status
NODE                          | STATE     | IP             | LAST SEEN
==========================================================================================
ak7_master_main               | online    | 0.0.0.0        | now
ak7_master_sub                | online    | 0.0.0.0        | now

TO-BE

root@42dot-ak7:~# bluechictl status
NODE                          | STATE     | IP                      | LAST SEEN
==========================================================================================
ak7_master_main               | online    | ::ffff:192.168.16.103   | now
ak7_master_sub                | online    | ::ffff:192.168.16.104   | now

Signed-off-by: Joonyoung Shim <joonyoung.shim@42dot.ai>

12 of 20 new or added lines in 3 files covered. (60.0%)

4765 of 5596 relevant lines covered (85.15%)

1038.24 hits per line