• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

unicode-org / icu4x / 9171808260
73%

Build:
DEFAULT BRANCH: main
Ran 21 May 2024 09:16AM UTC
Jobs 1
Files 959
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

21 May 2024 08:54AM UTC coverage: 76.113% (-0.002%) from 76.115%
9171808260

push

github

web-flow
Unifying `DataLocale` construction (#4912)

In preparation for #3632 

There are two cases:
* `DataLocales` that are passed into ICU4X constructors:
* These are constructed with `locale!("foo").into()`, or `"foo".parse()`
* When changing a constructor to preferences, the code doesn't need to
be changed if we add a `From<Locale>` impl for the preferences
* `DataLocales` that are put into the `DataRequest::locale` field.
* These are constructed with `langid!("foo").into()`, or `"foo".parse()`
* When changing the field to `&LanguageIdentifier`, these can be
clippy-cleaned-up, as the `.into()` will become redundant.

I've taken care to avoid having intermediate `Locale` or
`LanguageIdentifier` variables, everything that is macro-constructed is
immediately `into()`ed. This will simplify find-and-replace later.

110 of 121 new or added lines in 27 files covered. (90.91%)

6 existing lines in 4 files now uncovered.

53390 of 70146 relevant lines covered (76.11%)

506595.08 hits per line

Jobs
ID Job ID Ran Files Coverage
1 9171808260.1 21 May 2024 09:16AM UTC 0
76.11
GitHub Action Run
Source Files on build 9171808260
Detailed source file information is not available for this build.
  • Back to Repo
  • Github Actions Build #9171808260
  • 0776faf8 on github
  • Prev Build on main (#9162176690)
  • Next Build on main (#9177552647)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc