unioslo / mreg / 9171186643

98%

Build Type

push

github

Committed by web-flow

Commit Message

Django 4 support: Option 5, migrating to django-filter (v2) (#492)

* Fixes #487 by implementing option 5 in the issue.

Supports: python3.7+, django 3.2+. Tests included for this range.
Breaking changes: None

This implementation uses django-filter as intended. It sets a default filter backend and uses standard filter_class models where possible.

Exceptions take place in the following views:

HostList. Relies on manipulating the queryset, and said manipulation is also used in the filter-less HostDetail.
*Zone*List. The abstraction model for these views is based around propagating a filterset into the parent class.
Concerns:

This patch creates explicit mapping filters for JSONField and CIDRField. It is unclear how well-tested these are.

* Update pyproject.toml fix package building (for tox)

  - Required as we intriduced the toml file for ruff.
  - Sets some default keys.
  - Make tox.ini use the lint and coverage environments.
  - Make tox runs that use pythons and django show versions for both.

* A few cleanup fixes.

  - Uses filterset_class correctly.
  - Applies the filter via MregMixin.
  - Test basic filtering in hostgroups.

* Hack support CI-fields.

  - Requires manual lookup declarations.
  - See https://github.com/unioslo/mreg/issues/489#issuecomment-1610209358

* Rebase to master, clean up imports a bit.

* Cleanup after rebase.

* Remove unused variable.

Run Details

304 of 305 new or added lines in 9 files covered. (99.67%)

17 existing lines in 7 files now uncovered.

7014 of 7085 relevant lines covered (99.0%)

4.94 hits per line