unioslo / mreg / 9171186643
98%

DEFAULT BRANCH: master
Ran
Jobs 5
Files 83
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 98.998% (-0.2%) from 99.164%
9171186643

push

github

web-flow 
Django 4 support: Option 5, migrating to django-filter (v2) (#492)

* Fixes #487 by implementing option 5 in the issue.

Supports: python3.7+, django 3.2+. Tests included for this range.
Breaking changes: None

This implementation uses django-filter as intended. It sets a default filter backend and uses standard filter_class models where possible.

Exceptions take place in the following views:

HostList. Relies on manipulating the queryset, and said manipulation is also used in the filter-less HostDetail.
*Zone*List. The abstraction model for these views is based around propagating a filterset into the parent class.
Concerns:

This patch creates explicit mapping filters for JSONField and CIDRField. It is unclear how well-tested these are.

* Update pyproject.toml fix package building (for tox)

  - Required as we intriduced the toml file for ruff.
  - Sets some default keys.
  - Make tox.ini use the lint and coverage environments.
  - Make tox runs that use pythons and django show versions for both.

* A few cleanup fixes.

  - Uses filterset_class correctly.
  - Applies the filter via MregMixin.
  - Test basic filtering in hostgroups.

* Hack support CI-fields.

  - Requires manual lookup declarations.
  - See https://github.com/unioslo/mreg/issues/489#issuecomment-1610209358

* Rebase to master, clean up imports a bit.

* Cleanup after rebase.

* Remove unused variable.

304 of 305 new or added lines in 9 files covered. (99.67%)

17 existing lines in 7 files now uncovered.

7014 of 7085 relevant lines covered (99.0%)

4.94 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
99.31
 0.85% mreg/api/v1/views.py

Uncovered Existing Lines

Lines Coverage ∆ File
1
98.63
 -1.37% mreg/tests/test_model_network.py
1
97.37
 -2.63% hostpolicy/api/permissions.py
2
99.47
 -0.53% mreg/api/v1/tests/tests_zones.py
2
99.78
 -0.22% mreg/api/v1/tests/tests.py
2
96.55
 -1.35% mreg/models/zone.py
3
97.8
 -1.31% mreg/api/permissions.py
6
88.75
 -7.2% mreg/api/v1/history.py
Jobs
ID Job ID Ran Files Coverage
1 python-3.10 - 9171186643.1 83
99.0
 GitHub Action Run
2 python-3.7 - 9171186643.2 83
98.97
3 python-3.11 - 9171186643.3 83
99.0
 GitHub Action Run
4 python-3.9 - 9171186643.4 83
98.98
 GitHub Action Run
5 python-3.8 - 9171186643.5 83
98.98
 GitHub Action Run
Source Files on build 9171186643