1216
77%

Ran 11 Apr 2014 10:18PM UTC

Jobs 1

Files 175

Run time 41s

Badge

Embed ▾

pending completion

Build # 1216

Build Type

Pull #513

travis-ci

Committed by

MarcWeber

Commit Message

comment this line because its causing gcc warnings (didn't even know that gcc is
that smart ! - smarter than it should) - but in the end its right:

  if (top > curbuf->b_ml.ml_line_count
      || top >= bot
      || bot > curbuf->b_ml.ml_line_count + 1)

Let's rewrite:

  if ( top > N  // 1
      || top >= bot // 2
      || N + 1 < bot) // 3

  If 1 is not true, then we know top <= N, adding line 3 we get:

  Now  top <= N < N + 1 < bot

  Thus top <= bot, thus line 2 will never be true, thus it can be
  dropped. Thanks to roxfan @ #gcc to help me understand this.
  gcc 4.7's error message is still very strange:

    src/undo.c:253:7: error: assuming signed overflow does not occur when assuming that (X - c) > X is always false [-Werror=strict-overflow]
       || top >= bot
       ^
    cc1: all warnings being treated as errors

Pull Request Pull Request #513: gcc is too smart

Run Details

64540 of 107755 relevant lines covered (59.9%)

99267.05 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	78.23	3.2%	src/undo.c
9	79.22	1.09%	src/path.c
12	44.0	-48.31%	src/os/env.c
15	83.48	-12.25%	src/os/fs.c
23	22.86	-66.03%	src/os/users.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	1216.1	11 Apr 2014 10:18PM UTC	176	59.89	Travis Job 1216.1

Source Files on build 1216

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

neovim / neovim / 1216
77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1216

neovim / neovim / 1216 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1216

neovim / neovim / 1216
77%

README BADGES
x