stacklok / minder / 9159810114

53%

Build Type

push

github

Committed by web-flow

Commit Message

Improve error handling for `GetCredentialStateForProvider` (#3373)

The `GetCredentialStateForProvider` swallows an error since it was
originally written for a codepath where the error was not important.
Since then, it is used in a second place where the error is important.
I'm not sure if it's possible for the error to get triggered in
practice, but I managed to trigger the error path while writing unit
tests, which led to a strange and hard to debug error happening after
the error was skipped over.

Refactor this function to return an error. Ignore it in the call site
where it should be ignored, and react to it where it is significant. As
a nice side effect of this change, the control flow of
`GetCredentialStateForProvider` is significantly simplified.

Some unrelated unit test improvements from an ongoing development branch
have also been added to this branch.

Run Details

8 of 23 new or added lines in 4 files covered. (34.78%)

1 existing line in 1 file now uncovered.

9411 of 18839 relevant lines covered (49.95%)

52.43 hits per line