ocaml / dune / 27002

7%

Build Type

push

github

Committed by web-flow

Commit Message

scheduler: extract memo invalidation from the status field (#10518)

The accumulation of the invalidation is orthogonal to what the build
status is. Regardless of how the build progresses, we should always
continually combine new build input change into the current
invalidation, and we should only set the invalidation to empty when we
also call Memo.reset with the current invalidation.

At the same time, it also makes sense to cleanup the handling of the
"build_input_change" ivar. There is no need for it to be an option that
is initialized on-demand, since it is easy and cheap to just create an
initial ivar. In addition, we shouldn't care what the current build
status is when waiting for a file to change. (I suspect that some of the
reason for the complication is due to the "--react-to-insignificant-file changes"
flag that no longer exists.

This patch doesn't claim to fix any bugs; it's just intended as a code
cleanup.

Signed-off-by: Philip White <code@trailingwhite.space>
Co-authored-by: Philip White <code@trailingwhite.space>

Run Details

0 of 28 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

2911 of 42084 relevant lines covered (6.92%)

27067.37 hits per line