Qiskit / rustworkx / 9139666696

94%

Build Type

push

github

Committed by web-flow

Commit Message

Loosen trait constraints and simplify structure for longest_path (#1195)

In the recently merged #1192 a new generic DAG longest_path function was
added to rustworkx-core. However, the trait bounds on the function were
a bit tighter than they needed to be. The traits were forcing NodeId to
be of a NodeIndex type and this wasn't really required. The only
requirement that the NodeId type can be put on a hashmap and do a
partial compare (that implements Hash, Eq, and PartialOrd). Also the
IntoNeighborsDirected wasn't required because it's methods weren't ever
used. This commit loosens the traits bounds to facilitate this. At the
same time this also simplifies the code structure a bit to reduce the
separation of the rust code structure in the rustworkx crate using
longest_path().

Run Details

33 of 33 new or added lines in 2 files covered. (100.0%)

6 existing lines in 1 file now uncovered.

16744 of 17356 relevant lines covered (96.47%)

1215562.32 hits per line