• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ooni / probe-cli / 9128527407
83%
master: 72%

Build:
Build:
LAST BUILD BRANCH: refactor/no-forks
DEFAULT BRANCH: master
Ran 17 May 2024 12:58PM UTC
Jobs 1
Files 555
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

17 May 2024 12:52PM UTC coverage: 83.204% (+0.02%) from 83.186%
9128527407

push

github

bassosimone
fix(cli/rm/rm.go): using panic is not user friendly (#1608)

I manually tested the cli and concluded that it's too easy to reach the
panic caused by runtimex.Try0 over there and it would expose panics to
users too frequently.

Let's just convert those into normal error checks. Here is what we would
previously get:

```
% ./ooniprobe rm
? Are you sure you wish to delete the result #0  [Use arrows to move, type to filter]
  true
> false
panic: Try0: interrupt

[...]
```

So, here I just pressed ^D and got a panic. Ouch!

After the diff, we have this:

```
% ./ooniprobe rm
? Are you sure you wish to delete the result #0 false
   ⨯ failure in main command   error=canceled by user
```

and:

```
% ./ooniprobe rm --all
? Are you sure you wish to delete ALL results false
   ⨯ failure in main command   error=canceled by user
```

It seems much better, isn't it?

Part of the QA for https://github.com/ooni/probe/issues/2722

26959 of 32401 relevant lines covered (83.2%)

53.03 hits per line

Jobs
ID Job ID Ran Files Coverage
1 0 - 9128527407.1 17 May 2024 12:58PM UTC 0
83.2
GitHub Action Run
Source Files on build 9128527407
Detailed source file information is not available for this build.
  • Back to Repo
  • 71077f82 on github
  • Prev Build on master (#9082183844)
  • Next Build on release/3.22 (#9188547022)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc