EsupPortail / Esup-Pod / 9128443077

71%

main: 71%

push

github

[DONE] Code improvements (#1121)

* QoC:
* replace some == by === in JS
* correct some double quotes in shell scripts
* Add some missing types in .py
* Replace `len(xxx.sites.all())` by `xxx.sites.count()`
* Remove unused vars in Php

* Test with Coveralls report

* QoC

* Python 3.8 compatibility

* PHP Code formatting

* Test with AndreMiras/coveralls-python-action

* add missing types
+ replace remaining xml.dom by defusedxml
+ replace some == by === in JS

* add misisng quotes in shell scripts
+ always run apt-get clean AFTER apt-get install
+ use --no-install-recommends on every apt-get install

* try to run coverage without --source (it takes source frome coveragerc)

* Add Codacy coverage reporter

* Ignore *_settings.py in flake8

* Omit custom settings files in coverage
+ generate cobertura.xml coverage report

* Js:
* Tell ESlint to use "module" type for some scripts
* tell parseInt functions to use 10 base
* replace some innerHTML by textContent

+ PHP code formatting

* forgotten files in previous commit

* PHP code formatting

* code formatting

* correct lang file

* Replace remaining innerHTML by textContent in js files
and replace some == by ===

* minor remaining code formatting

* Delete the docker apt-get lists after each install

* add missing quotes

* declare some `i` vars in JS `for` loops

* JS vars declarations

* :shirt: Remove some linter warnings

* Remove unused JS functions

* Remove merge artifacts

* Cleanup merge artifacts

* Add unit tests for video apps.py

* Flake8

* Disable the "branch" coverage option

* revert textContent by innerHTML when content contains tags
+ include compiled .mo lang files

167 of 171 new or added lines in 21 files covered. (97.66%)

11424 of 16009 relevant lines covered (71.36%)

0.71 hits per line