9128515895
72%

Ran 17 May 2024 12:57PM UTC

Jobs 1

Files 555

Run time 1min

Badge

Embed ▾

Committed 17 May 2024 12:51PM UTC coverage: 83.18% (-0.01%) from 83.192%

Build # 9128515895

Build Type

push

github

Committed by

web-flow

Commit Message

fix(cli/rm/rm.go): using panic is not user friendly (#1608)

I manually tested the cli and concluded that it's too easy to reach the
panic caused by runtimex.Try0 over there and it would expose panics to
users too frequently.

Let's just convert those into normal error checks. Here is what we would
previously get:

```
% ./ooniprobe rm
? Are you sure you wish to delete the result #0  [Use arrows to move, type to filter]
  true
> false
panic: Try0: interrupt

[...]
```

So, here I just pressed ^D and got a panic. Ouch!

After the diff, we have this:

```
% ./ooniprobe rm
? Are you sure you wish to delete the result #0 false
   ⨯ failure in main command   error=canceled by user
```

and:

```
% ./ooniprobe rm --all
? Are you sure you wish to delete ALL results false
   ⨯ failure in main command   error=canceled by user
```

It seems much better, isn't it?

Part of the QA for https://github.com/ooni/probe/issues/2722

Run Details

26951 of 32401 relevant lines covered (83.18%)

52.46 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	0 - 9128515895.1	17 May 2024 12:57PM UTC	0	83.18	GitHub Action Run

Source Files on build 9128515895

Detailed source file information is not available for this build.

ooni / probe-cli / 9128515895
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9128515895

ooni / probe-cli / 9128515895 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9128515895

ooni / probe-cli / 9128515895
72%

README BADGES
x