rust-bitcoin / rust-bitcoin / 9112676334

83%

push

github

Merge rust-bitcoin/rust-bitcoin#2774: Use concrete type for all_zeros call

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/f3c80ea820ca63326acc22f0ba23cc9dc0811794">f3c80ea82 Use concrete type for all_zeros call (Tobin C. Harding)

Pull request description:

  Currently we use the `Hash` trait in a bunch of places to call `all_zeros`. We are attempting to improve the `hashes` API and this usage is both unnecessary and also hindering that effort.

  Use the concrete type (e.g. `BlockHash`) instead of calling through the trait method.

  Refactor only, no logic changes.

ACKs for top commit:
  apoelstra:
    ACK f3c80ea820ca63326acc22f0ba23cc9dc0811794 I contend that this meets one-ACK carve-out #4 "code moves that do not change the API"

Tree-SHA512: a8d7ba48c9ef689c78e33f8e97962514919

14 of 14 new or added lines in 5 files covered. (100.0%)

19303 of 23168 relevant lines covered (83.32%)

16846.73 hits per line