tarantool / tarantool / 9108575972

88%

Build Type

push

github

Committed by locker

Commit Message

vinyl: fix use-after-free of LSM tree in scheduler

Between picking an LSM tree from a heap and taking a reference to it in
vy_task_new() there are a few places where the scheduler may yield:
 - in vy_worker_pool_get() to start a worker pool;
 - in vy_task_dump_new() to wait for a memory tree to be unpinned;
 - in vy_task_compaction_new() to commit an entry to the metadata log
   after splitting or coalescing a range.

If a concurrent fiber drops and deletes the LSM tree in the meanwhile,
the scheduler will crash. To avoid that, let's take a reference to
the LSM tree.

It's quite difficult to write a functional test for it without a bunch
of ugly error injections so we rely on fuzzing tests.

Closes #9995

NO_DOC=bug fix
NO_TEST=fuzzing

Run Details

67438 of 119853 branches covered (56.27%)

9 of 10 new or added lines in 1 file covered. (90.0%)

48 existing lines in 12 files now uncovered.

100152 of 115003 relevant lines covered (87.09%)

2451729.57 hits per line