vocdoni / vocdoni-node / 9108516493

61%

main: 63%

Build Type

Pull #1307

github

Committed by altergui

Commit Message

refactor genesis package

* don't pass genesisBytes as arg on SetNode, NewVochain, newTendermint, etc

* notably, now cometbft has it's own datadir separate from our state,
  allowing to wipe cometbft data without wiping our state.

* drop genesis.AutoUpdateGenesis
* instead of comparing local and hardcoded genesis Hash, compare ChainID
  to decide wether to wipe out just cometbft, whole datadir, or do nothing
* cmd/node: add flags to override genesis ChainID, InitialHeight and AppHash
* cmd/node: add flag to schedule an EndOfChain

* move SeedNodes from genesis into config package (DefaultSeedNodes)
* add config consts: DefaultCometBFTPath and DefaultGenesisPath

* testsuite: use genesis.go instead of hardcoded genesis.json
    this increases the code coverage of testsuite and helps
    developing refactors of genesis.go
* now testsuite network is `test` (instead of `dev`)

* app.genesisDoc is now populated during newTendermint, instead of
  pulling from app.NodeClient.Genesis, since it's needed during Info() handshake

* cometbft: removed redundant app.State.SetHeight(lastHeight) during Info()

* cometbft: now Info() supports doing a chain bump, if genesis InitialHeight > lastHeight
* cometbft: now ProcessProposal supports stopping the current chain at height config.Forks.EndOfChain

* genesis: remove copypasted types, use upstream comettypes directly
* genesis: deduplicate ConsensusParams literals using DefaultBlockParams, etc
* genesis: remove useless hardcoded StateSyncParams
* genesis: add a simple unit test TestSaveAsAndLoad

Pull Request Pull Request #1307: refactor genesis handling to allow changing ChainID

Coverage Stats

141 of 241 new or added lines in 11 files covered. (58.51%)

14 existing lines in 7 files now uncovered.

15990 of 26214 relevant lines covered (61.0%)

37416.37 hits per line