Ouranosinc / xscen / 9102420731

87%

push

github

Fix template + update_attr bug (#405)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #404 
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [ ] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGES.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* A few fixes to the templates due to changes in xscen and xarray
* Fix #404, I don't know why this worked in the past but not now. From
my understanding there were 2 problems:
1) We iterate over `others` and assign it to `others`. This breaks the
iteration.
2) In the first instance, we pass a dict of dataset to create a dict of
str (l.137). Then, when we iterate over `others` in l.147, it is no
longuer a dict of dataset, we can't get to `attrs`.
Let me know if I misunderstood something.

### Does this PR introduce a breaking change?
i don't think so.

### Other information:

2 of 3 new or added lines in 1 file covered. (66.67%)

2976 of 4000 relevant lines covered (74.4%)

5.84 hits per line