9100657329
0%

Ran 15 May 2024 06:32PM UTC

Jobs 3

Files 0

Run time 1min

Badge

Embed ▾

Committed 15 May 2024 06:11PM UTC coverage: 0.0%. Remained the same

Build # 9100657329

Build Type

push

github

Committed by

web-flow

Commit Message

Fix setConsent to properly use the `update` gtag command (#8243)

We wrap the gtag function internally and pass setConsent calls through the wrapper function, which in turn calls the gtag SDK. While we invoke the wrapped function with parameters identical to those listed in the gtag functions, we were dropping the update string on the floor inside the wrapped function. Additionally, we were feeding the consentSettings as the second parameter to gag, which should have been the update string parameter.

This ended up clobbering the data, and not send update commands properly.

This change fixes our wrappedGtag func impl to properly pass update to gtag, along with the provided ConsentSettings argument.

Closes #8210

Run Details

0 of 0 relevant lines covered (NaN%)

0.0 hits per line

Jobs

ID	Job ID	Ran
1	9100657329.1	15 May 2024 06:32PM UTC	GitHub Action Run
2	9100657329.2	15 May 2024 06:34PM UTC	GitHub Action Run
3	9100657329.3	15 May 2024 06:54PM UTC	GitHub Action Run

firebase / firebase-js-sdk / 9100657329
0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9100657329

firebase / firebase-js-sdk / 9100657329 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9100657329

firebase / firebase-js-sdk / 9100657329
0%

README BADGES
x