stacklok / minder / 9079916128
53%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 190
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 49.135% (-0.2%) from 49.285%
9079916128

push

github

web-flow 
Make artifacts ingester work with both GitHub and OCI providers (#3309)

* Make artifacts ingester work with both GitHub and OCI providers

This modifies the ingester to change its behavior depending on whether
the provider is an OCI provider or a github one.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

* Pass in OCI authenticator to container verifier

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

* Fix getting registry from OCI provider

It's used differently than I thought

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

* Use tags as versions

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

* Fix mindev

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

* Use a vesrsion name dict for github compatibility

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

* Run `go mod tidy`

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

* Fix dockerhub rule evaluation and rename versions

The logic to refer to containers is now changed to using the `Sha` field
from the ArtifactVersions since this is what the bebavior was. With
this, we can now evaluate policies with the dockerhub provider!!

The usage of the word version around the verifier was misleading, so
this was fixed so the code and expectations are easier to follow.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

---------

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

74 of 188 new or added lines in 7 files covered. (39.36%)

6 existing lines in 3 files now uncovered.

9030 of 18378 relevant lines covered (49.13%)

53.49 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
54.26
 0.0% internal/verifier/sigstore/sigstore.go
4
0.0
 0.0% internal/providers/dockerhub/dockerhub.go
8
0.78
 0.0% internal/verifier/sigstore/container/container.go
25
0.0
 0.0% internal/providers/oci/oci.go
29
68.28
 -6.34% internal/engine/ingester/artifact/artifact.go
45
39.19
 internal/engine/ingester/artifact/versioner.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
0.0
 0.0% internal/providers/dockerhub/dockerhub.go
2
75.85
 -0.85% internal/eea/eea.go
3
68.28
 -6.34% internal/engine/ingester/artifact/artifact.go
Jobs
ID Job ID Ran Files Coverage
1 9079916128.1 190
49.13
 GitHub Action Run
Source Files on build 9079916128