kubevirt / containerized-data-importer / #4597

49%

push

travis-ci

Fix flaky DataImportCron controller reconcile loop unit test (#3256)

This change caused a unit test to be flaky:
https://github.com/kubevirt/containerized-data-importer/pull/3176/files#

Before, this code would round down to the second, and add 1. Essentially
doing a "ceil" on the time delta.

After the change, the round-down part disappeared, so it became a plain
+1 rather than a ceil.

The unit test in question has an assertion ensuring that this value is
within 0 and 60.

If this value is within 59 and 60:
- Before #3176: rounds up to 60 (test passes)
- After #3176: is mapped to within 60 and 61 (test fails)

I didn't want to revert to the old code because it was a bit confusing,
so I removed the +1, which I understand it's there to make sure we
don't undershoot (no longer necessary as we don't round down anymore).

Signed-off-by: Edu Gómez Escandell <egomez@redhat.com>

1 of 1 new or added line in 1 file covered. (100.0%)

13077 of 21256 relevant lines covered (61.52%)

0.69 hits per line